Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/keykeeper api sign rpm #1

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Conversation

josephtate
Copy link
Owner

Just a quick PR so that it's easy to see all that's changed.

josephtate and others added 29 commits November 8, 2024 16:18
* refactors signing and checksig methods out of SignArtifactActivity
* Sorts imports
* uses CombinedOutput instead of a buffer for thread safety
* removes existing, unused python rules
* downloads rules_pkg and loads dependencies
- Sorts sync-replace entries alphabetically
  - More compatible with go mod tidy
- Removes obsolete ioutil calls
- sorts imports: prettier
* New protected key, signed like keykeeper does on import.
* Remove history file (gitignore)
* Type interface:
  * This lets us replace individual methods in test mocks to simplify unit testing
  * Only contains EnsureGPGKey so far
* Also adds workingDir so that tests do not need root  access
* Fixes deprecated random seeding
* Adds gpgCmdEnv to the struct functions
* This lets it know the workingDir
* Also update ioutil use
…y or duplicated

* Add checksig and sign RPM to Server to make use of gpgCmdEnv
* Use interface to call EnsureGPGKey
* Use workingDir for paths
* Allows tests to run against more versions of gpg
* Allows tests to run on more systems
* Reduces confusion about GNUPGHOME by a small amount
* Also adds gpg-agent and keyboxd cleanups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants