forked from rocky-linux/peridot
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/keykeeper api sign rpm #1
Open
josephtate
wants to merge
29
commits into
main
Choose a base branch
from
feat/keykeeper-api-sign-rpm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactors signing and checksig methods out of SignArtifactActivity * Sorts imports * uses CombinedOutput instead of a buffer for thread safety
* removes existing, unused python rules * downloads rules_pkg and loads dependencies
- Sorts sync-replace entries alphabetically - More compatible with go mod tidy - Removes obsolete ioutil calls - sorts imports: prettier
* New protected key, signed like keykeeper does on import. * Remove history file (gitignore)
* Type interface: * This lets us replace individual methods in test mocks to simplify unit testing * Only contains EnsureGPGKey so far * Also adds workingDir so that tests do not need root access * Fixes deprecated random seeding * Adds gpgCmdEnv to the struct functions
* This lets it know the workingDir * Also update ioutil use
…y or duplicated * Add checksig and sign RPM to Server to make use of gpgCmdEnv * Use interface to call EnsureGPGKey * Use workingDir for paths
* Allows tests to run against more versions of gpg
* Allows tests to run on more systems * Reduces confusion about GNUPGHOME by a small amount * Also adds gpg-agent and keyboxd cleanups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a quick PR so that it's easy to see all that's changed.